Skip to content

test: add Headers coverage and benchmark - #25

Draft
anonrig wants to merge 1 commit into
mainfrom
cursor/headers-class-performance-859a
Draft

test: add Headers coverage and benchmark#25
anonrig wants to merge 1 commit into
mainfrom
cursor/headers-class-performance-859a

Conversation

@anonrig

@anonrig anonrig commented Aug 18, 2026

Copy link
Copy Markdown
Owner

Node-side tests and benchmark only. No deps/undici changes.

Open in Web Open in Cursor 

Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.

Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
@cursor
cursor Bot force-pushed the cursor/headers-class-performance-859a branch from 3ea8120 to eb22154 Compare August 18, 2026 01:59
@cursor cursor Bot changed the title deps: improve Headers class performance test: add Headers coverage and benchmark Aug 18, 2026
@cursor
cursor Bot force-pushed the cursor/headers-class-performance-859a branch from eb22154 to 2edacb0 Compare August 18, 2026 02:06

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2edacb0. Configure here.


// Keep a live use so V8 cannot DCE the loop.
if (result === Symbol.for('benchmark-never'))
throw new Error('unreachable');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete benchmark DCE prevention

Medium Severity

The anti-DCE guard only observes result, but construct-*, set, append, and delete never assign it, so those timed loops can be eliminated. Other Node benchmarks keep the last constructed or mutated value alive with an assignment plus assert.ok. As written, those methods may report misleading throughput.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2edacb0. Configure here.

@cursor
cursor Bot force-pushed the cursor/headers-class-performance-859a branch from 2edacb0 to 0225f7b Compare August 18, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant