Removing Custom...Server.java classes and replacing with Thrift implementation#6454
Removing Custom...Server.java classes and replacing with Thrift implementation#6454Amemeda wants to merge 7 commits into
Conversation
|
|
||
| @Override | ||
| public <T> T unwrap(Class<T> iface) { | ||
| return null; |
There was a problem hiding this comment.
I think we should throw an UnsupportedOperationException here. According to the ServerContext javadoc, this is the correct action.
There was a problem hiding this comment.
This still needs to be done I think
| } | ||
|
|
||
| return new ServerAddress(new CustomNonBlockingServer(options), address); | ||
| CustomNonBlockingServer server = new CustomNonBlockingServer(options); |
There was a problem hiding this comment.
It appears the CustomNonBlockingServer is also custom solely to get the client address. We might be able to remove this as well.
There was a problem hiding this comment.
Ive removed that one, I think that's all the custom server classes. The only remaining custom classes I see are CustomObjectMapper and CustomHsHaNestedIT
Amemeda
changed the title
| TThreadPoolServer.Args options = new TThreadPoolServer.Args(transport); | ||
| options.protocolFactory(protocolFactory); | ||
| options.transportFactory(transportFactory); | ||
| options.processorFactory(new ClientInfoProcessorFactory(clientAddress, processor)); |
There was a problem hiding this comment.
I'm not sure that this is needed anymore (the method call and the ClientInfoProcessorFactory class). Look at other calls to 'processorFactory' to see how they are used in this class.
|
|
||
| @Override | ||
| public <T> T unwrap(Class<T> iface) { | ||
| return null; |
There was a problem hiding this comment.
This still needs to be done I think
4 participants
Investigated relevance of CustomThreadedSelectorServer.java
return new ServerAddress(new CustomThreadedSelectorServer(options), address);Result:
setServerEventHandler(new ThriftServerEventHandler());to applicable tservers