Remove redundant minimalMavenBuildVersion override#6467
Merged
Conversation
Member
Author
|
Verified the effective POM shows the expected 3.9 after removing the local override: |
ctubbsii
requested changes
Jul 9, 2026
ctubbsii
left a comment
Member
There was a problem hiding this comment.
This is fine, but should be applied to 2.1 first and merged to main. I try to keep the build stuff up-to-date on all our active branches, because it helps ensure a smooth release, rather than just apply this stuff to main.
e16b8bb to
30204b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the local
minimalMavenBuildVersionproperty from the pom.Apache parent pom version 36 added the same Maven 3.9 minimum via a PR I made at apache/maven-apache-parent#533. We use version 37 which includes this so the override is now redundant and we can remove it.
Refs: