Preserve ${...} placeholders when removing/modifying networkConnectors in RuntimeConfigurationPlugin#2123
Open
jbonofre wants to merge 1 commit into
Open
Conversation
NetworkConnectorProcessor.configMatch compared raw DTO values (still
holding ${...} placeholders) against the live NetworkConnector whose
attributes had already been resolved by Spring. A connector declared
with placeholders could therefore never be matched for removal or
modification by the RuntimeConfigurationPlugin. Filter the DTO props
through placeHolderUtil before comparing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
NetworkConnectorProcessor.configMatchso it resolves${...}placeholders on the DTO side before comparing against the liveNetworkConnector(whose attributes are already resolved by Spring). Without this, a networkConnector declared with placeholders could never be matched for removal or modification by the RuntimeConfigurationPlugin.Adds a test covering
uri,userName, andpasswordplaceholders across removal.