Skip to content

AVRO-4268: BytesWritableConverter should respect logical length #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanSkraba merged 1 commit into from
Jul 19, 2026
+16 −1
Merged

AVRO-4268: BytesWritableConverter should respect logical length #3878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lang/java/mapred/src/main/java/org/apache/avro/hadoop/io/AvroDatumConverterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public BytesWritableConverter() {
/** {@inheritDoc} */
@Override
public ByteBuffer convert(BytesWritable input) {
return ByteBuffer.wrap(input.getBytes());
return ByteBuffer.wrap(input.getBytes(), 0, input.getLength());
}

/** {@inheritDoc} */
Expand Down
15 changes: 15 additions & 0 deletions lang/java/mapred/src/test/java/org/apache/avro/hadoop/io/TestAvroDatumConverterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,21 @@ void convertBytesWritable() {
assertEquals(3, bytes.get(2));
}

@Test
void convertBytesWritableRespectsLogicalLength() {
AvroDatumConverter<BytesWritable, ByteBuffer> converter = mFactory.create(BytesWritable.class);
byte[] backing = new byte[] { 1, 2, 3, 4, 5 };
BytesWritable writable = new BytesWritable(backing);
writable.setSize(3);

ByteBuffer bytes = converter.convert(writable);

assertEquals(3, bytes.remaining());
assertEquals(1, bytes.get(0));
assertEquals(2, bytes.get(1));
assertEquals(3, bytes.get(2));
}

@Test
void convertByteWritable() {
AvroDatumConverter<ByteWritable, GenericFixed> converter = mFactory.create(ByteWritable.class);
Expand Down
Loading