Limit AMF string and array parsing#3353
Merged
chenBright merged 1 commit intoJun 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: null
Problem Summary:
AMF parsing accepted declared string lengths and array counts directly from the input stream. Malformed RTMP/AMF payloads could make the parser reserve excessive memory or spend a long time walking impossible element counts before discovering that the stream was incomplete.
What is changed and the side effects?
Changed:
Side effects:
Performance effects: AMF string parsing now copies through a small stack buffer, avoiding large zero-fill allocations for malformed payloads.
Breaking backward compatibility: AMF payloads whose string length or array count exceed the new defaults will be rejected. The defaults are 64 MiB per string and 1,048,576 array elements.
Check List: