Fix empty Redis command array parsing#3354
Merged
chenBright merged 1 commit intoJun 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: null
Problem Summary:
The Redis command parser accepted an empty RESP array as the start of a command
and kept parsing subsequent bulk strings as array elements. Since an empty array
has no command name or arguments, this input should be rejected by the parser.
What is changed and the side effects?
Changed:
RedisCommandParser.CHECKwith an explicit parse error beforewriting parsed bulk strings into the argument vector.
Side effects:
Performance effects: None expected.
Breaking backward compatibility: Empty RESP arrays are now rejected as invalid
Redis commands.
Check List: