Skip to content

fix(release): address 0.43.0 RC feedback - #882

Merged
elijahbenizzy merged 2 commits into
mainfrom
release_fixes
Sep 12, 2026
Merged

fix(release): address 0.43.0 RC feedback#882
elijahbenizzy merged 2 commits into
mainfrom
release_fixes

Conversation

@jernejfrank

@jernejfrank jernejfrank commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Address the non-blocking follow-ups reported while verifying 0.43.0 RC1:

  • install the Graphviz Python package through the tests extra
  • derive the official build epoch from the anchored Git HEAD timestamp
  • recover and propagate that same epoch from source and sdist archive members for voter/CI rebuilds
  • retain byte-for-byte SHA-512 verification of rebuilt sdists
  • update the tracking UI transitive nanoid dependency from 3.3.16 to 3.3.18
  • make UI CI use a clean lockfile install and non-mutating ESLint/Prettier checks
  • fix the existing UI formatting findings and enforce zero lint warnings

Validation

  • release/verifier/Graphviz tests — 39 passed
  • Python 3.9 syntax check
  • full isolated release plus voter rebuild — rebuilt sdist SHA-512 and wheel contents matched
  • extracted-sdist wheel build without .git — passed
  • clean npm ci
  • npm audit — zero vulnerabilities
  • npm run build
  • npx vitest run — 1 passed
  • npm run lint
  • npm run format
  • LICENSE-wheel covers all 130 bundled npm packages
  • focused pre-commit hooks — passed

@github-actions github-actions Bot added area/ui Burr UI (telemetry frontend) area/ci Workflows, build, release scripts labels Aug 13, 2026
@jernejfrank
jernejfrank force-pushed the release_fixes branch 2 times, most recently from 3c0c59b to 9d1ad56 Compare August 13, 2026 08:49
Use the source commit epoch throughout release and voter rebuilds so byte-for-byte sdist verification is reproducible. Fix the tracking UI nanoid advisory and enforce clean lint and formatting checks.
Resolves conflicts with #899 in scripts/apache_release.py and its test.
@elijahbenizzy

Copy link
Copy Markdown
Contributor

Merged main into this branch so it's mergeable again (conflicted with #899). Kept #899's tempdir sdist build and layered the git-anchored SOURCE_DATE_EPOCH env on top of it. Only other edit: retargeted the monkeypatch in the #899 test from _source_date_epoch to _git_source_date_epoch, since this PR removes the former. Tests, pre-commit, and the stricter UI lint/format gate all pass locally. Will approve once CI is green.

@elijahbenizzy elijahbenizzy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the conflict resolution against #899 and re-ran tests, pre-commit, and the UI lint/format gate locally. LGTM.

@elijahbenizzy
elijahbenizzy merged commit e833e4f into main Sep 12, 2026
30 checks passed
@elijahbenizzy
elijahbenizzy deleted the release_fixes branch September 12, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci Workflows, build, release scripts area/ui Burr UI (telemetry frontend)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants