Skip to content

[CALCITE-7665] Convert multi-value NOT IN to AND of NOT_EQUALS in SqlToRelConverter - #5121

Merged
xuzifu666 merged 1 commit into
apache:mainfrom
xuzifu666:calcite-7665
Aug 30, 2026
Merged

[CALCITE-7665] Convert multi-value NOT IN to AND of NOT_EQUALS in SqlToRelConverter#5121
xuzifu666 merged 1 commit into
apache:mainfrom
xuzifu666:calcite-7665

Conversation

@xuzifu666

Copy link
Copy Markdown
Member

@sonarqubecloud

Copy link
Copy Markdown

@xuzifu666 xuzifu666 added the discussion-in-jira There's open discussion in JIRA to be resolved before proceeding with the PR label Jul 27, 2026
@xuzifu666

Copy link
Copy Markdown
Member Author

I have conducted further research to supplement the discussion regarding Jira: in terms of resolving this issue, the approach in the current PR is likely the simplest; it aims to determine the correct plan upfront without relying on the simplification performed by Simplify. cc @mihaibudiu

@xuzifu666

Copy link
Copy Markdown
Member Author

I have shared my views in Jira regarding the issues raised by @julianhyde ; I will likely need to fully confirm everything is in order before merging this PR.

@xuzifu666

Copy link
Copy Markdown
Member Author

This PR has been open for a long time; unless there are objections, I plan to merge it within the coming week.

@xuzifu666 xuzifu666 added LGTM-will-merge-soon Overall PR looks OK. Only minor things left. and removed discussion-in-jira There's open discussion in JIRA to be resolved before proceeding with the PR labels Aug 25, 2026
@sonarqubecloud

Copy link
Copy Markdown

@xuzifu666
xuzifu666 merged commit cc1dcc4 into apache:main Aug 30, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants