Skip to content

[CALCITE-7751] Skipped CI jobs when adding labels - #5229

Open
zabetak wants to merge 1 commit into
apache:mainfrom
zabetak:CALCITE-7751
Open

[CALCITE-7751] Skipped CI jobs when adding labels#5229
zabetak wants to merge 1 commit into
apache:mainfrom
zabetak:CALCITE-7751

Conversation

@zabetak

@zabetak zabetak commented Aug 29, 2026

Copy link
Copy Markdown
Member

Jira Link

CALCITE-7751

Changes Proposed

  1. Split CI jobs requiring labels in its own workflow file.
  2. Remove skip logic based on labels from main.yml.

@zabetak zabetak added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Aug 29, 2026
@zabetak

zabetak commented Aug 29, 2026

Copy link
Copy Markdown
Member Author

I added the LGTM label immediately to test that jobs are not going to be skipped.

@zabetak

zabetak commented Aug 29, 2026

Copy link
Copy Markdown
Member Author

As expected the Slow Tests job was skipped since the appropriate label is missing.

@zabetak

zabetak commented Aug 29, 2026

Copy link
Copy Markdown
Member Author

Just added the "slow-tests-needed" label and the respective action started running leaving all the rest untouched.

@xiedeyantu xiedeyantu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I like this change!

@xiedeyantu

Copy link
Copy Markdown
Member

Just added the "slow-tests-needed" label and the respective action started running leaving all the rest untouched.

Exactly as expected — I just happened to see this trigger effect!

@mihaibudiu

Copy link
Copy Markdown
Contributor

YAML+github actions is one of these things which I never put an effort to learn (it's really a top contender to the title of the "Worst language ever designed"), so I can't review this myself.
It's great if it does solve the problem.

name: 'Linux (JDK 8) Slow Tests'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since you touched this: I wonder if we need to use newer checkout action...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left. slow-tests-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants