CAMEL-24854: the validator reports an include/exclude regex with a doubled backslash, which matches no file

[davsclaus]

Description

From the round-2 benchmark (series l3): after the validator's hint for include: ".*\.json$" (an unknown escape in double quotes, correctly answered with write the value in single quotes: '.*\.json$'), the model wrote include: '.*\\.json$', doubling the backslash as a Java string would. Inside single quotes YAML keeps both, the regex then matches a file name containing a literal backslash, no file matched, and the route ran ten seconds in silence. A person used to Java strings makes the same slip.

EndpointChecks.checkRegexOptions, which already parses include/exclude on the file components, now reports a value with a doubled backslash:

Line 5: file: include=.*\\.json$ matches a backslash in the file name (in single quotes one backslash escapes the dot): write include='.*\.json$'

Tests

SourceValidatorEndpointTest.aDoubledBackslashInAnIncludeRegexIsReported: the doubled form is reported with the form to write, the single-backslash form is not.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Bp3538HRBPMQkb5ta9xRaj

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run
• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
• You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
• Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[gnodet-bot]

The detection logic and fix suggestion are correct — a doubled backslash in YAML single-quoted include/exclude produces a regex that matches a literal backslash in the filename instead of the intended pattern, so the route runs in silence. One nit on the user-facing error message wording.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[gnodet-bot]

Two issues with the new check in checkRegexOptions.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[gnodet-bot]

Both previous findings addressed:

• Wording nit ✅ — parenthetical now correctly explains regex semantics (\\ is one literal backslash, \. matches a dot), no longer conflates with YAML single-quote escaping rules.
• False-positive on intentional \\ ✅ — value.contains("\\\\") replaced with DOUBLED_BACKSLASH_ESCAPE.matcher(value).find(), which only fires when \\ precedes a character that \ would escape in a regex (., d, s, w, b, (, [, {, etc.). The .*\\myfile.* case is now correctly left alone, with a test to prove it.

The pattern itself is correct — checked the character class: [.dswDSWbB()\[\]{}+*?|^$] matches all regex shorthands and metacharacters where a doubled backslash is a user mistake, while leaving intentional literal-backslash patterns (\\m, \\f, etc.) untouched.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[github-actions]

🧪 CI tested the following changed modules:

• dsl/camel-jbang/camel-jbang-core

---

🔬 Scalpel shadow comparison — Scalpel: 6 of 692 tested, 8 compile-only — current: 6 all tested

Maveniverse Scalpel detected 15 affected modules (current approach: 6).

Skip-tests mode would test 6 modules (1 direct + 6 downstream), skip tests for 8 (generated code, meta-modules)

⚠️ Modules only in Scalpel (9)

• camel-jbang-core
• camel-jbang-it
• camel-jbang-main
• camel-jbang-plugin-edit
• camel-jbang-plugin-generate
• camel-jbang-plugin-kubernetes
• camel-jbang-plugin-test
• camel-launcher
• coverage

Modules Scalpel would test (6)

• camel-jbang-core ← dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ai/EndpointChecks.java, dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ai/YamlLines.java, dsl/camel-jbang/camel-jbang-core/src/test/java/org/apache/camel/dsl/jbang/core/commands/ai/SourceValidatorEndpointTest.java
• camel-jbang-mcp ← downstream of org.apache.camel:camel-jbang-core
• camel-jbang-plugin-mcp ← downstream of org.apache.camel:camel-jbang-core
• camel-jbang-plugin-route-parser ← downstream of org.apache.camel:camel-jbang-core
• camel-jbang-plugin-tui ← downstream of org.apache.camel:camel-jbang-core
• camel-jbang-plugin-validate ← downstream of org.apache.camel:camel-jbang-core
• camel-launcher-container ← downstream of org.apache.camel:camel-launcher

Modules with tests skipped (8)

• camel-jbang-it
• camel-jbang-main
• camel-jbang-plugin-edit
• camel-jbang-plugin-generate
• camel-jbang-plugin-kubernetes
• camel-jbang-plugin-test
• camel-launcher
• coverage

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

⚠️ Some tests are disabled on GitHub Actions (@DisabledIfSystemProperty(named = "ci.env.name")) and require manual verification:

• dsl/camel-jbang/camel-jbang-core: 2 test(s) disabled on GitHub Actions

💡 Manual integration tests recommended:

You modified dsl/camel-jbang/camel-jbang-core. The related integration tests in dsl/camel-jbang/camel-jbang-it are excluded from CI. Consider running them manually:

mvn verify -f dsl/camel-jbang/camel-jbang-it -Djbang-it-test

All tested modules (15 modules, 3m 9s total)

Total reactor time: 3m 9s

Module	Duration	Status
Camel :: Launcher	58.0s	SUCCESS
Camel :: JBang :: MCP	45.2s	SUCCESS
Camel :: JBang :: Plugin :: TUI	38.5s	SUCCESS
Camel :: JBang :: Plugin :: Kubernetes	17.6s	SUCCESS
Camel :: JBang :: Plugin :: Testing	9.8s	SUCCESS
Camel :: JBang :: Plugin :: Validate	6.6s	SUCCESS
Camel :: Coverage	5.1s	SUCCESS
Camel :: JBang :: Plugin :: Edit	1.6s	SUCCESS
Camel :: JBang :: Plugin :: Route Parser	1.5s	SUCCESS
Camel :: JBang :: Plugin :: Generate	1.3s	SUCCESS
Camel :: JBang :: Plugin :: MCP	1.1s	SUCCESS
Camel :: JBang :: Main	1.0s	SUCCESS
Camel :: JBang :: Integration tests	0.9s	SUCCESS
Camel :: Launcher :: Container	0.8s	SUCCESS
Camel :: JBang :: Core	n/a

Top 20 slowest modules:

• Camel :: Launcher (58.0s)
• Camel :: JBang :: MCP (45.2s)
• Camel :: JBang :: Plugin :: TUI (38.5s)
• Camel :: JBang :: Plugin :: Kubernetes (17.6s)
• Camel :: JBang :: Plugin :: Testing (9.8s)
• Camel :: JBang :: Plugin :: Validate (6.6s)
• Camel :: Coverage (5.1s)
• Camel :: JBang :: Plugin :: Edit (1.6s)
• Camel :: JBang :: Plugin :: Route Parser (1.5s)
• Camel :: JBang :: Plugin :: Generate (1.3s)
• Camel :: JBang :: Plugin :: MCP (1.1s)
• Camel :: JBang :: Main (1.0s)
• Camel :: JBang :: Integration tests (0.9s)
• Camel :: Launcher :: Container (0.8s)

---

⚙️ View full build and test results