CAMEL-24855: the file consumer says at INFO when it creates the starting directory it consumes from - #26638
Open
davsclaus wants to merge 2 commits into
Open
CAMEL-24855: the file consumer says at INFO when it creates the starting directory it consumes from#26638davsclaus wants to merge 2 commits into
davsclaus wants to merge 2 commits into
Conversation
…ing directory it consumes from, so a run that reads a directory that was not there is not silent Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bp3538HRBPMQkb5ta9xRaj
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet-bot
reviewed
Sep 20, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
Contributor
There was a problem hiding this comment.
COMMENT — One-line logging improvement; solid intent. Two minor nits below.
The change correctly addresses the silent-wait problem: when autoCreate=true and the directory gets created, users previously had no INFO-level signal explaining why the consumer wasn't delivering messages. Promoting this to INFO is the right fix.
No correctness issues. Backport to camel-4.22.x and camel-4.18.x looks warranted — the same silent-failure exists there. Milestone not set (should be 4.23.0 once the nits are resolved).
This review was generated by an AI agent, Hermès on behalf of @gnodet.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 482 of 692 tested, 28 compile-only — current: 482 all testedMaveniverse Scalpel detected 510 affected modules (current approach: 482). Skip-tests mode would test 482 modules (1 direct + 481 downstream), skip tests for 28 (generated code, meta-modules)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A route that consumes from a directory the project does not have (
from: file://orderswith the files next to the route instead) starts, creates the empty directory and waits: no error, no output, and nothing in the log says why. In the round-2 benchmark (series l3) 7 of 9 silent attempts were this shape; for a person prototyping withcamel runit is the hardest failure to read.The file consumer now logs at INFO when it creates the starting directory:
where before it said so only at debug. The line reaches every runtime and every log reader (
camel run, the camel-jbang-mcp log tool). A validator warning was considered and left out: the validator has no warning level (every message fails validation and blocks the MCP write tool), and an inbox another process fills is a legitimate route. The runtime line is the evidence; if the silent failures persist in the next series, a warning level can follow.Tests
The existing file consumer tests cover the auto-created directory; the change is one log statement on the success branch.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Bp3538HRBPMQkb5ta9xRaj