Skip to content

test: add parsing boundary unit tests for ComplexFormat #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lora-Scott wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −0
Open

test: add parsing boundary unit tests for ComplexFormat #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ...ons-math-legacy/src/test/java/org/apache/commons/math4/legacy/util/ComplexFormatTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,22 @@ protected char getDecimalCharacter() {
protected Locale getLocale() {
return Locale.US;
}
@Test
public void testParseBoundaryConditions() {
ComplexFormat format = ComplexFormat.getInstance();

// Test parsing empty string boundary
try {
format.parse("");
} catch (Exception ex) {
// Expected exception for empty input
}

// Test parsing garbage/invalid string boundary
try {
format.parse("invalid_complex_string");
} catch (Exception ex) {
// Expected exception for invalid input
}
Comment on lines +38 to +49

@1230fahid 1230fahid Jul 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, could we use org.junit.jupiter.api.Assertions.assertThrows; and assert that an Exception is thrown? Specifically a MathParseException?

}
}