Skip to content

fix ArrayIndexOutOfBoundsException in DnsStringLookup for '|' key - #765

Open
dxbjavid wants to merge 1 commit into
apache:masterfrom
dxbjavid:dns-lookup-delimiter-key
Open

fix ArrayIndexOutOfBoundsException in DnsStringLookup for '|' key#765
dxbjavid wants to merge 1 commit into
apache:masterfrom
dxbjavid:dns-lookup-delimiter-key

Conversation

@dxbjavid

Copy link
Copy Markdown
Contributor

DnsStringLookup.lookup splits the key on | and reads keys[0] before it checks the array length, so a key made up of only delimiter or whitespace characters (for example the interpolation ${dns:|}, or ||) splits to an empty array and throws an ArrayIndexOutOfBoundsException straight out of the public lookup instead of resolving to nothing. Every other split-based lookup in this package (FileStringLookup, UrlStringLookup, PropertiesStringLookup, XmlStringLookup, ScriptStringLookup, ResourceBundleStringLookup) guards the length before indexing, so this is the odd one out. I've returned null for that case, which is what the method already does for a null key and for a host that will not resolve, so the behaviour stays consistent and no valid key changes.

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant