Skip to content

feat: support for 'alwaysOutOfDate' PBX Shell Script property#173

Merged
erisu merged 2 commits into
apache:masterfrom
erisu:feat/always-out-of-date
Jun 18, 2026
Merged

feat: support for 'alwaysOutOfDate' PBX Shell Script property#173
erisu merged 2 commits into
apache:masterfrom
erisu:feat/always-out-of-date

Conversation

@erisu

@erisu erisu commented Jun 18, 2026

Copy link
Copy Markdown
Member

This PR cherry-picks the changes from PR #143, rebases them, and resolves the merge conflicts.

Since PR #143 is over two years old, I wasn't sure whether @marco-saia-datadog was still active or would be willing to rebase it. At the same time, I didn't want to rebase their branch on their behalf (if possible), as they may still be using their repository for their own projects.

Because this PR is based on a cherry-pick, the original author will still receive recognition for the work they contributed.

See #143 for any additional context and discussion around this feature.

This PR also:


Additional changes:

  • Updates alwaysOutOfDate to evaluate to 1 for any truthy value, including non-empty strings.
  • Updated tests to be strict equals.

@erisu erisu requested review from breautek and dpogue June 18, 2026 04:00
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.31%. Comparing base (9d908c4) to head (0bb75ce).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files          51       51           
  Lines       10940    10968   +28     
=======================================
+ Hits        10646    10674   +28     
  Misses        294      294           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erisu erisu merged commit 04fc2dd into apache:master Jun 18, 2026
12 checks passed
@erisu erisu deleted the feat/always-out-of-date branch June 18, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants