Skip to content

perf: remove per-partition copy, IPC context and flush from the native shuffle writer #5908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
andygrove wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

perf: remove per-partition copy, IPC context and flush from the native shuffle writer #5908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
833a8cc
perf: remove per-partition copy, IPC context and flush from the nativ…
andygrove Sep 13, 2026
f0d56de
docs: describe what the shared IPC context actually retains
andygrove Sep 13, 2026
673799a
test: use as_chunks for the index offsets, per clippy on Rust 1.98
andygrove Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions native/shuffle/src/shuffle_writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1200,7 +1200,7 @@ mod test {
#[test]
#[cfg_attr(miri, ignore)]
fn test_batch_coalescing_reduces_size() {
use crate::writers::BufBatchWriter;
use crate::writers::{BufBatchWriter, ShuffleScratch};
use arrow::array::Int32Array;

// Create a wide schema to amplify per-block schema overhead
Expand Down Expand Up @@ -1238,7 +1238,7 @@ mod test {
1024 * 1024,
8192,
);
let mut scratch = Vec::new();
let mut scratch = ShuffleScratch::default();
for batch in &small_batches {
buf_writer
.write(batch, &mut scratch, &encode_time, &write_time)
Expand All @@ -1259,7 +1259,7 @@ mod test {
1024 * 1024,
1,
);
let mut scratch = Vec::new();
let mut scratch = ShuffleScratch::default();
for batch in &small_batches {
buf_writer
.write(batch, &mut scratch, &encode_time, &write_time)
Expand Down Expand Up @@ -1326,7 +1326,7 @@ mod test {
#[test]
#[cfg_attr(miri, ignore)]
fn test_full_batches_bypass_coalescer() {
use crate::writers::BufBatchWriter;
use crate::writers::{BufBatchWriter, ShuffleScratch};
use arrow::array::Int32Array;

let schema = Arc::new(Schema::new(vec![Field::new("v", DataType::Int32, false)]));
Expand Down Expand Up @@ -1368,7 +1368,7 @@ mod test {
1024 * 1024,
batch_size as usize,
);
let mut scratch = Vec::new();
let mut scratch = ShuffleScratch::default();
for batch in &inputs {
buf_writer
.write(batch, &mut scratch, &encode_time, &write_time)
Expand Down
Loading
Loading