Skip to content

fix: preserve inner list field name, nullability and metadata in array_append/array_prepend/array_replace* #24350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
waterWang wants to merge 4 commits into from
+53 −6
Closed

fix: preserve inner list field name, nullability and metadata in array_append/array_prepend/array_replace* #24350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8245cef
fix: preserve inner list field name, nullability and metadata in arra…
waterWang Aug 13, 2026
2a8758b
fix: preserve inner list field name, nullability and metadata in arra…
waterWang Aug 13, 2026
4be9e12
fix: add internal_err import
waterWang Aug 13, 2026
195e075
fix: add internal_err import
waterWang Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions datafusion/functions-nested/src/concat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ use datafusion_common::utils::{
};
use datafusion_common::{
cast::as_generic_list_array,
exec_err, plan_err,
exec_err, internal_err, plan_err,
utils::{list_ndims, take_function_args},
};
use datafusion_expr::binary::type_union_resolution;
Expand Down Expand Up @@ -439,10 +439,21 @@ fn concat_internal<O: OffsetSizeTrait>(args: &[ArrayRef]) -> Result<ArrayRef> {
}

let data_type = list_arrays[0].value_type();
// Preserve the input list's inner field (name, nullability, metadata) instead
// of creating a new default field, matching the promised return type.
let field = match list_arrays[0].data_type() {
DataType::List(field) | DataType::LargeList(field) => Arc::clone(field),
other => {
return internal_err!(
"array_concat got unexpected data type: {}",
other
);
}
};
let data = mutable.freeze();

Ok(Arc::new(GenericListArray::<O>::try_new(
Arc::new(Field::new_list_field(data_type, true)),
field,
OffsetBuffer::new(offsets.into()),
arrow::array::make_array(data),
valid,
Expand Down Expand Up @@ -564,8 +575,20 @@ where

let data = mutable.freeze();

// Preserve the input list's inner field (name, nullability, metadata) instead
// of creating a new default field, matching the promised return type.
let field = match list_array.data_type() {
DataType::List(field) | DataType::LargeList(field) => Arc::clone(field),
other => {
return internal_err!(
"array_append/array_prepend got unexpected data type: {}",
other
);
}
};

Ok(Arc::new(GenericListArray::<O>::try_new(
Arc::new(Field::new_list_field(data_type.to_owned(), true)),
field,
OffsetBuffer::new(offsets.into()),
arrow::array::make_array(data),
None,
Expand Down
30 changes: 27 additions & 3 deletions datafusion/functions-nested/src/replace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ use arrow::buffer::OffsetBuffer;
use arrow::datatypes::{DataType, Field};
use datafusion_common::cast::as_int64_array;
use datafusion_common::utils::ListCoercion;
use datafusion_common::{Result, ScalarValue, exec_err, utils::take_function_args};
use datafusion_common::{Result, ScalarValue, exec_err, internal_err, utils::take_function_args};
use datafusion_expr::{
ArrayFunctionArgument, ArrayFunctionSignature, ColumnarValue, Documentation,
ScalarFunctionArgs, ScalarUDFImpl, Signature, TypeSignature, Volatility,
Expand Down Expand Up @@ -501,8 +501,20 @@ fn general_replace<O: OffsetSizeTrait>(

let data = mutable.freeze();

// Preserve the input list's inner field (name, nullability, metadata) instead
// of creating a new default field, matching the promised return type.
let field = match list_array.data_type() {
DataType::List(field) | DataType::LargeList(field) => Arc::clone(field),
other => {
return internal_err!(
"array_replace got unexpected data type: {}",
other
);
}
};

Ok(Arc::new(GenericListArray::<O>::try_new(
Arc::new(Field::new_list_field(list_array.value_type(), true)),
field,
OffsetBuffer::<O>::new(offsets.into()),
arrow::array::make_array(data),
valid.finish(),
Expand Down Expand Up @@ -597,8 +609,20 @@ fn general_replace_with_scalar<O: OffsetSizeTrait>(

let data = mutable.freeze();

// Preserve the input list's inner field (name, nullability, metadata) instead
// of creating a new default field, matching the promised return type.
let field = match list_array.data_type() {
DataType::List(field) | DataType::LargeList(field) => Arc::clone(field),
other => {
return internal_err!(
"array_replace got unexpected data type: {}",
other
);
}
};

Ok(Arc::new(GenericListArray::<O>::try_new(
Arc::new(Field::new_list_field(list_array.value_type(), true)),
field,
OffsetBuffer::new(offsets.into()),
arrow::array::make_array(data),
list_array.nulls().cloned(),
Expand Down