fix(build): commit generated mocks so fresh clones work with plain Go tooling - #9128
Open
bujjibabukatta wants to merge 1 commit into
Open
fix(build): commit generated mocks so fresh clones work with plain Go tooling#9128bujjibabukatta wants to merge 1 commit into
bujjibabukatta wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #9088
Summary
backend/mocks/is gitignored but imported by tracked source code(
helpers/unithelper) and test files (helpers/pluginhelper/api).On a fresh clone this breaks
go mod tidy,go build ./..., IDEtooling, and Dependabot's gomod ecosystem.
Root Cause
The mocks are generated via
mockerybut never committed. Sincehelpers/unithelperimports them directly (not as test-only code),Go can't find these packages on a clean checkout and tries to fetch
them as external modules, which fails.
Fix
backend/mocks/from.gitignore.make mock, mockery v3.7.4).No changes to
go.mod/go.sum.make mockand diff against the committedmocks, so they can't silently go stale.