[Fix][Master] Continue backfill after failed date - #18661
Open
MonsterChenzhuo wants to merge 1 commit into
Open
MonsterChenzhuo wants to merge 1 commit into
MonsterChenzhuo wants to merge 1 commit into
Conversation
MonsterChenzhuo
requested review from
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
September 22, 2026 04:51
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public void notifyWorkflowLifecycleEvent(final IWorkflowExecution workflowExecution, | ||
| final AbstractWorkflowLifecycleLifecycleEvent lifecycleEvent) { | ||
| final WorkflowInstance workflowInstance = workflowExecution.getWorkflowInstance(); | ||
| if (workflowInstance.getNextWorkflowInstanceId() > 0 |
| if (!backfillTriggerResponse.isSuccess()) { | ||
| log.warn("Backfill workflow failed: {}", backfillTriggerResponse.getMessage()); | ||
| } else { | ||
| workflowInstance.setNextWorkflowInstanceId(backfillTriggerResponse.getWorkflowInstanceId()); |
SbloodyS
reviewed
Sep 22, 2026
SbloodyS
left a comment
SbloodyS
left a comment
Member
There was a problem hiding this comment.
Please follow the pull request notice and create an issue first.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
yes
Purpose of the pull request
In parallel backfill mode, workflow instances currently generate the next backfill instance only after the current instance succeeds. If one date fails while the failure strategy is CONTINUE, all remaining dates in the same shard are stranded and never executed.
This pull request continues the backfill chain after failed dates when CONTINUE is configured, preserves the existing END behavior, prevents duplicate continuation triggers, and adds regression tests.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md