Skip to content

branch-4.1: [fix](regression) Enable expression pushdown for variant norms test - #68230

Merged
eldenmoon merged 1 commit into
apache:branch-4.1from
eldenmoon:branch-fix-variant-norms-test-4.1
Sep 20, 2026
Merged

eldenmoon merged 1 commit into
apache:branch-4.1from
eldenmoon:branch-fix-variant-norms-test-4.1

Conversation

@eldenmoon

@eldenmoon eldenmoon commented Sep 20, 2026

Copy link
Copy Markdown
Member

Follow-up to #68140.

Problem

test_variant_subcolumn_index_norms failed

match_phrase not support execute_match

The VARIANT MATCH predicate was not guaranteed to be pushed into the inverted index because the suite did not explicitly enable common expression pushdown. It then fell back to execute_match, which does not support MATCH_PHRASE.

Fix

Explicitly enable enable_common_expr_pushdown, matching the existing test_bm25_score_variant setup on branch-4.1.

Validation

  • Confirmed TeamCity build 1051635 failed at the first VARIANT MATCH_PHRASE query after table creation and insertion succeeded.
  • git diff --check passed.
  • Local regression execution is unavailable because the branch-4.1 BE build is blocked by the local thirdparty/toolchain environment; CI is required for runtime confirmation.

### What problem does this PR solve?

Issue Number: close apache#68039

Related PR: apache#68140

Problem Summary: The branch-4.1 regression environment can execute the VARIANT MATCH predicate outside the inverted index when common expression pushdown is not explicitly enabled. MATCH_PHRASE then falls back to execute_match, which is unsupported. Enable common expression pushdown explicitly, matching the existing VARIANT BM25 regression setup.

### Release note

None

### Check List (For Author)

- Test: Regression test configuration fix; TeamCity failure 1051635 reproduces the missing prerequisite
- Behavior changed: No
- Does this need documentation: No
@eldenmoon
eldenmoon requested a review from yiguolei as a code owner September 20, 2026 02:15
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon

Copy link
Copy Markdown
Member Author

run buildall

@eldenmoon
eldenmoon merged commit 1de45e2 into apache:branch-4.1 Sep 20, 2026
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants