[branch-4.1][fix](ngram-bf) Give up the NGRAM index when a LIKE pattern can carry an escape (#68021) - #68319
Open
selectdb-robot wants to merge 1 commit into
Open
[branch-4.1][fix](ngram-bf) Give up the NGRAM index when a LIKE pattern can carry an escape (#68021)#68319selectdb-robot wants to merge 1 commit into
selectdb-robot wants to merge 1 commit into
Conversation
… an escape (apache#68021) Give up the NGRAM index when a LIKE pattern can carry an escape (cherry picked from commit 2fe54ad) Adapt TabletReader guard to branch-4.1 function_filters and pred naming.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #68021
Backport #68021 to
branch-4.1to prevent NGRAM Bloom Filter pruning from dropping matching rows when a LIKE pattern contains a backslash or uses a custom ESCAPE. Escape-free patterns remain eligible for the index.Cherry-picked from
2fe54ad3516e0638444f91f4581d1127bb48a411.One conflict was resolved in
TabletReader::_init_conditions_param: retain branch-4.1'sfunction_filtersloop andis_like_predicate(pred)check, and addpred->can_do_bloom_filter(true)to the existing index initialization guard. The other BE changes and the regression suite are unchanged from the original patch.Validation
git diff --checkpassed; no unresolved conflicts.olap_scan_operator.cppandlike_column_predicate.hmatch the original commit.test_ngram_bloomfilter_index_like_escape.groovyis identical to the original commit.LikeState::has_custom_escape.Release note
Fix incorrect LIKE query results with NGRAM Bloom Filter indexes when the pattern contains an escape.
Check List (For Author)
Check List (For Reviewer who merge this PR)