branch-4.1: [fix](fetype) Commit FE type only after transition completes #68302 - #68325
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
### What problem does this PR solve? Problem Summary: A non-master FE transition can be interrupted when a newer BDB state is queued while the listener waits for metadata readiness. The listener previously still committed the target FE type even though non-master initialization, including MetricRepo.init(), had not run. A repeated FOLLOWER or OBSERVER notification was then treated as redundant, leaving the FE in an incompletely initialized state. This change makes transferToNonMaster() report whether the transition completed and updates feType only after all initialization finishes. An interrupted transition retains the previous committed state so the queued event is evaluated against the state that was actually initialized and can retry the transition. ### Release note Fix FE state transitions that could leave a follower or observer serving queries before non-master initialization completed.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #68302