feat: Update to Calcite 1.42.0. - #19976
Open
gianm wants to merge 1 commit into
Open
Conversation
Main changes: 1) Sync of Parser.jj (using dev/upgrade-calcite-parser) and CalcitePlanner. 2) Add DruidTypeFactory to work around undesirable behavior introduced by CALCITE-7358. 3) Add validation to prevent aliases in CLUSTERED BY, which have been added to the parser since CALCITE-5347. (The change is done at the validator instead of the parser to minimize parser diffs.) 4) Adjust test expectations for slightly different plans.
FrankChen021
left a comment
FrankChen021
left a comment
Member
There was a problem hiding this comment.
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 0 |
| P2 | 1 |
| P3 | 0 |
| Total | 1 |
Reviewed 21 of 21 changed files.
This is an automated review by Codex GPT-5.6-Luna(max)
| } | ||
|
|
||
| // Aliases like "CLUSTERED BY col AS alias" are not allowed. | ||
| if (clusteredByNode.isA(ImmutableSet.of(SqlKind.AS))) { |
Member
There was a problem hiding this comment.
[P2] Alias hidden by NULLS FIRST
expr AS alias NULLS FIRST becomes NULLS_FIRST(AS(expr, alias)), so the top-level AS check misses it. The node is then carried into clustering/order-by handling and can produce an invalid cluster-key mapping. Reject aliases recursively through ordering wrappers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
Sync of Parser.jj (using dev/upgrade-calcite-parser) and
CalcitePlanner.
Add DruidTypeFactory to work around undesirable behavior introduced
by CALCITE-7358.
Add validation to prevent aliases in CLUSTERED BY, which have been
added to the parser since CALCITE-5347. (The change is done at the
validator instead of the parser to minimize parser diffs.)
Adjust test expectations for slightly different plans.