Skip to content

minor: diagnostics when MSQ's on-demand segment cache can't fit an input segment - #19985

Draft
cecemei wants to merge 2 commits into
apache:masterfrom
cecemei:storage
Draft

minor: diagnostics when MSQ's on-demand segment cache can't fit an input segment #19985
cecemei wants to merge 2 commits into
apache:masterfrom
cecemei:storage

Conversation

@cecemei

@cecemei cecemei commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description

MSQ workers read input segments through a virtual-storage cache (SegmentLocalCacheManager/StorageLocation) sized as a fraction of tmpStorageBytesPerTask. If a single segment exceeds that cache's capacity, it fails unconditionally (nothing can be evicted to make room), and the resulting error gives no numbers, just "ensure enough disk space has been allocated." The actual size/capacity data was already computed for a debug log line but never surfaced. This PR is diagnostics-only, no behavior change.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions Bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant