fix: filter columns by java field name for camel case field names - #1130
Open
CodeMan-cmd wants to merge 1 commit into
Open
CodeMan-cmd wants to merge 1 commit into
CodeMan-cmd wants to merge 1 commit into
Conversation
The column filter compared the name kept by the cglib bean map of a field with the field names configured through includeColumnFieldNames/excludeColumnFieldNames. For a field whose name starts with a lower case letter followed by an upper case letter, for example xRealIp or pName, the two names differ, so includeColumnFieldNames dropped the column and excludeColumnFieldNames kept it. The reorder by include list also assigned a position to an unknown column name, which shifted the following columns.
Open
2 tasks
skytin1004
approved these changes
Sep 24, 2026
Contributor
There was a problem hiding this comment.
Thanks for the fix. Using the Java field name is the right approach because include/exclude names are supplied through the public API, and skipping unknown names avoids gaps in the requested column order. I reproduced the issue with the previous implementation and verified the fix. All relevant tests passed locally with Java 11. LGTM.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The column filter compared the name kept by the cglib bean map of a field with the field names configured through includeColumnFieldNames/excludeColumnFieldNames. For a field whose name starts with a lower case letter followed by an upper case letter, for example xRealIp or pName, the two names differ, so includeColumnFieldNames dropped the column and excludeColumnFieldNames kept it. The reorder by include list also assigned a position to an unknown column name, which shifted the following columns.
Purpose of the pull request
What's changed?
Checklist