feat: add java.sql.Clob converter - #1134
Open
AhmedYoussef98 wants to merge 1 commit into
Open
AhmedYoussef98 wants to merge 1 commit into
AhmedYoussef98 wants to merge 1 commit into
Conversation
skytin1004
approved these changes
Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Related to #1017
What's changed?
Adds a default
java.sql.Clobconverter. Clob values are written to Excel as string cells by reading their character stream. String cells are converted back to detachedSerialClobinstances, avoiding database-specific implementations.The converter is registered for default reads and writes. Unit tests cover converter keys, both conversion directions, and loader registration.
Verification
./mvnw package -B -Dmaven.test.skip=false -Dtest=ClobStringConverterTest,DefaultConverterLoaderTest -Dsurefire.failIfNoSpecifiedTests=false -pl fesod-common,fesod-shaded,fesod-sheet— 8 tests passed../mvnw spotless:check -B— passed.The full spreadsheet suite did not complete on macOS because
CompatibilityTest.readWithCacheAfterTempDeletionrecursed repeatedly throughFileUtils.delete; the targeted converter and loader tests passed.Checklist