Skip to content

[FLINK-40382][tests] Execute the serializer test variants in flink-table-type-utils #28962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
spuru9 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[FLINK-40382][tests] Execute the serializer test variants in flink-table-type-utils #28962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 42 additions & 31 deletions ...-utils/src/test/java/org/apache/flink/table/runtime/typeutils/ExternalSerializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
import org.apache.flink.table.types.DataType;
import org.apache.flink.types.Row;

import org.junit.jupiter.api.Nested;

import java.lang.reflect.Array;
import java.util.ArrayList;
import java.util.Arrays;
Expand All @@ -32,37 +34,24 @@
import java.util.Objects;

/** Tests for {@link ExternalSerializer}. */
abstract class ExternalSerializerTest<T> extends SerializerTestInstance<T> {

@SuppressWarnings("unchecked")
ExternalSerializerTest(TestSpec<T> testSpec) {
super(
ExternalSerializer.of(testSpec.dataType),
(Class<T>) testSpec.dataType.getConversionClass(),
testSpec.length,
testSpec.instances.toArray(
(T[]) Array.newInstance(testSpec.dataType.getConversionClass(), 0)));
}

@Override
protected boolean allowNullInstances(TypeSerializer<T> serializer) {
return true;
}
class ExternalSerializerTest {

static final class ExternalSerializer1Test extends ExternalSerializerTest {
public ExternalSerializer1Test() {
@Nested
final class ExternalSerializer1Test extends ExternalSerializerTestBase<Integer> {
ExternalSerializer1Test() {
super(
TestSpec.forDataType(DataTypes.INT())
TestSpec.<Integer>forDataType(DataTypes.INT())
.withLength(4)
.addInstance(18)
.addInstance(42));
}
}

static final class ExternalSerializer2Test extends ExternalSerializerTest {
public ExternalSerializer2Test() {
@Nested
final class ExternalSerializer2Test extends ExternalSerializerTestBase<Row> {
ExternalSerializer2Test() {
super(
TestSpec.forDataType(
TestSpec.<Row>forDataType(
DataTypes.ROW(
DataTypes.FIELD("age", DataTypes.INT()),
DataTypes.FIELD("name", DataTypes.STRING())))
Expand All @@ -71,10 +60,11 @@ public ExternalSerializer2Test() {
}
}

static final class ExternalSerializer3Test extends ExternalSerializerTest {
public ExternalSerializer3Test() {
@Nested
final class ExternalSerializer3Test extends ExternalSerializerTestBase<ImmutableTestPojo> {
ExternalSerializer3Test() {
super(
TestSpec.forDataType(
TestSpec.<ImmutableTestPojo>forDataType(
DataTypes.STRUCTURED(
ImmutableTestPojo.class,
DataTypes.FIELD("age", DataTypes.INT()),
Expand All @@ -84,10 +74,12 @@ public ExternalSerializer3Test() {
}
}

static final class ExternalSerializer4Test extends ExternalSerializerTest {
public ExternalSerializer4Test() {
@Nested
final class ExternalSerializer4Test
extends ExternalSerializerTestBase<List<ImmutableTestPojo>> {
ExternalSerializer4Test() {
super(
TestSpec.forDataType(
TestSpec.<List<ImmutableTestPojo>>forDataType(
DataTypes.ARRAY(
DataTypes.STRUCTURED(
ImmutableTestPojo.class,
Expand All @@ -106,15 +98,34 @@ public ExternalSerializer4Test() {
}
}

static final class ExternalSerializer5Test extends ExternalSerializerTest {
public ExternalSerializer5Test() {
@Nested
final class ExternalSerializer5Test extends ExternalSerializerTestBase<Integer[]> {
ExternalSerializer5Test() {
super(
TestSpec.forDataType(DataTypes.ARRAY(DataTypes.INT()))
TestSpec.<Integer[]>forDataType(DataTypes.ARRAY(DataTypes.INT()))
.addInstance(new Integer[] {0, 1, null, 3})
.addInstance(new Integer[0]));
}
}

abstract static class ExternalSerializerTestBase<T> extends SerializerTestInstance<T> {

@SuppressWarnings("unchecked")
ExternalSerializerTestBase(TestSpec<T> testSpec) {
super(
ExternalSerializer.of(testSpec.dataType),
(Class<T>) testSpec.dataType.getConversionClass(),
testSpec.length,
testSpec.instances.toArray(
(T[]) Array.newInstance(testSpec.dataType.getConversionClass(), 0)));
}

@Override
protected boolean allowNullInstances(TypeSerializer<T> serializer) {
return true;
}
}

// --------------------------------------------------------------------------------------------

private static class TestSpec<T> {
Expand Down
Loading