Skip to content

[GLUTEN-12412][VL] Almalinux CI followup - #13085

Open
zhouyuan wants to merge 10 commits into
apache:mainfrom
zhouyuan:wip-almalinux-followup
Open

zhouyuan wants to merge 10 commits into
apache:mainfrom
zhouyuan:wip-almalinux-followup

Conversation

@zhouyuan

@zhouyuan zhouyuan commented Sep 21, 2026

Copy link
Copy Markdown
Member

What changes are proposed in this pull request?

followup to improve the CI script

  • bump rsync action version
  • use container name in the action job

How was this patch tested?

pass GHA

Was this patch authored or co-authored using generative AI tooling?

Related issue: #12412

Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
@github-actions github-actions Bot added the INFRA label Sep 21, 2026
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
Signed-off-by: Yuan <yuanzhou@apache.org>
@zhouyuan
zhouyuan marked this pull request as ready for review September 21, 2026 20:19
@zhouyuan
zhouyuan requested review from philo-he and a lite review from Copilot September 21, 2026 20:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The x86 nightly job no longer populates the Arrow-jar artifact path required by downstream packaging jobs.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

Moves Velox CI builds into AlmaLinux 8 container jobs, updates CentOS 9 cache/artifact naming, and upgrades rsync deployment actions.

Changes:

  • Containerizes nightly, enhanced, and cache native builds.
  • Renames ARM cache and artifact identifiers for CentOS 9.
  • Updates rsync deployment action pins.
File Description
.github/​workflows/​velox_nightly.yml AlmaLinux build and rsync updates
.github/​workflows/​velox_backend_enhanced.yml Containerized enhanced native build
.github/​workflows/​velox_backend_cache.yml Containerized cache builds and key updates
.github/​workflows/​velox_backend_arm.yml CentOS 9 job and artifact naming
.github/​workflows/​nightly_sync.yml rsync action upgrade

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +55 to +56
bash dev/ci-velox-buildstatic-centos-8.sh
ccache -s
Signed-off-by: Yuan <yuanzhou@apache.org>
Copilot AI review requested due to automatic review settings September 21, 2026 20:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The x86 nightly job no longer copies Arrow jars from /root/.m2, so its uploaded artifact is missing and downstream packaging jobs fail.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 High severity

Open (2)

yum install bison -y
df -a
export CCACHE_MAXSIZE=1G
bash dev/ci-velox-buildstatic-centos-8.sh
Signed-off-by: Yuan <yuanzhou@apache.org>
Copilot AI review requested due to automatic review settings September 22, 2026 08:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The nightly x86 Arrow upload path is malformed, and newly containerized cache jobs omit dependencies required by Apache Stash actions.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 3 High severity

Open (3)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Stash save lacks gh and jq dependencies in container

.github/​workflows/​velox_backend_cache.yml:36

This job now runs apache/infrastructure-actions/stash/save inside the AlmaLinux container (at lines 56-61), but the image only provides the base Python and does not include the gh/jq dependencies that stash actions require. The cache job will therefore fail while saving to Apache Stash; install the stash dependencies in the container before the actions, or keep this action on the host runner.

This issue also appears on line 134 of the same file.

Comment thread .github/workflows/velox_nightly.yml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 22, 2026 08:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 3 High severity · 1 Low severity

Open (4)
Resolved since last review (1)

dnf install -y jq bison tzdata
dnf module -y install python39 && alternatives --set python3 /usr/bin/python3.9
dnf config-manager --add-repo https://cli.github.com/packages/rpm/gh-cli.repo
dnf install -y gh --setopt=gpgcheck=0
path: ./cpp/build/releases/
if-no-files-found: error

tpc-test-centos8:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants