Merge 8.0.x into 8.1.x

[jamesfredley]

Description

Merge current 8.0.x into 8.1.x so the 8.1 line receives the already-landed 8.0 work, including #16178 (Grails 8 compile stays indy-off via CompilePlugin).

This is a release-line merge, not a squash. Git resolved it with the ort strategy and no conflicts. projectVersion remains 8.1.0-SNAPSHOT.

Carried from 8.0.x:

• build: disable Groovy invokedynamic for the Grails 8 compile #16178: CompilePlugin sets optimizationOptions.indy = false (CI can still pass -PgrailsIndy=true)
• Databinding Map constructors and GormStaticApi.count() logger capture for indy-off
• Groovydoc runtime classpath (jboss-logging) from build(ci): bound concurrent JVMs on the macOS runner #16167
• CI daemon-heap comments and macOS --max-workers cap from build(ci): bound concurrent JVMs on the macOS runner #16167

Contributor Checklist

Issue and Scope

• This PR is linked to an existing issue that has been acknowledged or approved by the project team. If no approved issue exists, please give background on why this change is necessary. Tickets are preferred for release change log history.
• This PR addresses the complete scope of the linked issue. Partial implementations or unfinished work should not be submitted for review.
• This PR contains a single, focused change. Unrelated changes should be submitted as separate pull requests.
• This PR targets the correct branch for the type of change:
  • Patch release branches (e.g., 7.0.x): Bug fixes only. No new features or API changes.
  • Minor release branches (e.g., 7.1.x): New features are welcome, but breaking existing APIs must be avoided.
  • Major release branches (e.g., 8.0.x): Reserved for major changes. Breaking API changes are permitted.

Code Quality

• I have added or updated tests that cover the changes introduced in this PR. All code contributions are expected to include appropriate test coverage.
• I have verified that all existing tests pass by running ./gradlew build --rerun-tasks.
• My code follows the project's code style guidelines. I have run ./gradlew codeStyle and resolved any violations. See Code Style for details.
• This PR does not include mass reformatting, style-only changes, or large-scale refactoring unless it was explicitly approved in the linked issue. Unsolicited reformatting will not be accepted.
• If generative AI tooling was used in preparing this contribution, a quality model was used to ensure contributions are consistent with the project's quality standards.

Licensing and Attribution

• All contributed code is provided under the Apache License 2.0, and new source files include the appropriate Apache license header.
• I have the necessary rights to submit this contribution and confirm it is my own original work (see Legal Notice).
• If generative AI tooling was used in preparing this contribution, I have followed the Apache Software Foundation's policy on generative tooling and have properly attributed its use.

Documentation

• If this PR introduces user-facing changes, I have included or updated the relevant documentation.
• If this PR adds a new feature, I have updated the What's New section of the Grails Guide.
• If this PR introduces breaking changes or changes that require user action during an upgrade, I have updated the Upgrade Notes for the corresponding version in the Grails Guide.
• The PR description clearly explains what was changed and why.

Generative AI (Cursor Grok 4.6) was used to complete the merge.

[Copilot]

🟢 Approval recommended

The changes appear consistent with the stated merge goals, include targeted regression tests for the key indy-off behaviors, and do not introduce confirmed correctness or configuration hazards in the reviewed hunks.

Pull request overview

This PR merges the current 8.0.x line into 8.1.x, bringing forward build defaults and runtime/test fixes needed for Groovy invokedynamic disabled by default (via CompilePlugin), along with CI and Groovydoc reliability improvements.

Changes:

• Centralize Groovy invokedynamic (indy) default to false in CompilePlugin, while keeping -PgrailsIndy=true as an opt-in (including whitespace-tolerant parsing).
• Fix databinding instantiation for nested types that only expose Map constructors under @CompileStatic + indy-off, and adjust tests accordingly.
• Improve Groovydoc robustness by extending its classpath with runtime dependencies, and constrain macOS CI concurrency to reduce memory pressure.

File summaries

File	Description
grails-web-databinding/src/main/groovy/grails/web/databinding/GrailsWebDataBinder.groovy	Uses shared Map-constructor instantiation helper for nested binding under indy-off.
grails-test-suite-persistence/src/test/groovy/grails/web/databinding/GrailsWebDataBinderSpec.groovy	Adjusts Map-constructor test fixture to avoid null as boolean under indy-off.
grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/GormStaticApi.groovy	Prevents logger calls in count() from being dispatched through methodMissing by capturing the logger before entering callbacks.
grails-datamapping-core/src/test/groovy/org/grails/datastore/gorm/GormStaticApiSpec.groovy	Adds regression coverage ensuring count() runs without triggering the methodMissing/logger dispatch failure.
grails-databinding-core/src/main/groovy/grails/databinding/SimpleDataBinder.groovy	Introduces newInstanceFromMapArguments(...) using InvokerHelper to reliably invoke Map ctors under @CompileStatic with indy disabled.
gradle/grails-extension-gradle-config.gradle	Makes grailsIndy parsing whitespace-tolerant and consistent with the build-logic property lookup behavior.
gradle.properties	Documents CI/local heap budgeting and why macOS caps workers rather than shrinking the daemon heap.
build-logic/plugins/src/main/groovy/org/apache/grails/buildsrc/CompilePlugin.groovy	Sets the default GroovyCompile indy flag via grailsIndy property (default false) for published artifacts.
build-logic/plugins/src/test/groovy/org/apache/grails/buildsrc/CompilePluginSpec.groovy	Adds TestKit coverage for indy default/override and whitespace trimming.
build-logic/plugins/src/main/groovy/org/apache/grails/buildsrc/GroovydocEnhancerPlugin.groovy	Extends Groovydoc task classpath with runtimeClasspath to avoid NoClassDefFoundError from runtime-only transitives.
build-logic/plugins/src/test/groovy/org/apache/grails/buildsrc/GroovydocEnhancerPluginSpec.groovy	Adds coverage ensuring Groovydoc sees runtime-only jars on its classpath.
.github/workflows/gradle.yml	Caps macOS --max-workers and test parallelism via matrix runner_arguments.

Review details

• Files reviewed: 12/12 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.7075%. Comparing base (2545945) to head (42a30d7).

Files with missing lines	Patch %	Lines
.../grails/web/databinding/GrailsWebDataBinder.groovy	0.0000%	2 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##                8.1.x     #16318        +/-   ##
==================================================
- Coverage     55.8236%   55.7075%   -0.1161%     
- Complexity      21437      21441         +4     
==================================================
  Files            2146       2146                
  Lines          102616     102663        +47     
  Branches        18160      18197        +37     
==================================================
- Hits            57284      57191        -93     
  Misses          37382      37382                
- Partials         7950       8090       +140     

Files with missing lines	Coverage Δ
.../groovy/grails/databinding/SimpleDataBinder.groovy	74.3210% <100.0000%> (-0.1840%)	⬇️
...ovy/org/grails/datastore/gorm/GormStaticApi.groovy	76.1290% <100.0000%> (-0.2464%)	⬇️
.../grails/web/databinding/GrailsWebDataBinder.groovy	30.0341% <0.0000%> (-0.0513%)	⬇️

... and 64 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[codeconsole]

You are creating new merges from 8.0.x when 8.0.x is currently in a broken state from a merge from. 7.x

Shouldn't we be doing merges sequentially? Why create 8.1.x into 9.0.x before 8.0.x has been merged into 8.1.x?

[testlens-app]

✅ All tests passed ✅

🏷️ Commit: 42a30d7
▶️ Tests: 74531 executed
⚪️ Checks: 85/85 completed

---

Learn more about TestLens at testlens.app/docs.