Conversation
…new workflow Signed-off-by: leehaut <leehaut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8620
Summary
Creating a pipeline or workflow stores the default name (
New pipeline/New workflow). With "Synchronize name with filename" enabled (the default), the UI shows the name derived from the filename, but XML serialization writes the storednamefield. Saving asTest Pipeline.hpltherefore left<name>New pipeline</name>in the file. The same happened for workflows.getXml()now copies that filename-derived name into the persisted field before serialization, for both pipelines and workflows. A custom name is left unchanged when synchronization is turned off. Renaming a closed file in the explorer uses the samegetXml()path, so that case is covered too.Test plan
Test Pipeline.hpl. The file contains<name>Test Pipeline</name>, notNew pipelineTest Workflow.hwf:<name>Test Workflow</name>.<name>keeps that custom name../mvnw -pl engine test -Dtest=PipelineMetaTest,WorkflowMetaTest