Optimize HPACK full match lookup - #706
Merged
arturobernalg merged 1 commit intoSep 28, 2026
Merged
Conversation
ok2c
reviewed
Sep 28, 2026
| } | ||
| for (int i = 0; i < entries.size(); i++) { | ||
| final HPackEntry entry = entries.get(i); | ||
| for (final HPackEntry entry : entries) { |
Member
There was a problem hiding this comment.
@arturobernalg Does this use Iterator underneath? Can we make it explicit?
Member
Author
There was a problem hiding this comment.
Does this use
Iteratorunderneath? Can we make it explicit?
@ok2c Yes, the enhanced for-loop uses an Iterator underneath. changed
Avoid indexed access when traversing dynamic table entries. Use sequential iteration for linked lists.
arturobernalg
force-pushed
the
hpack-optimize-full-match-lookup
branch
from
September 28, 2026 14:07
8f09b2b to
8723d60
Compare
ok2c
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OutboundDynamicTable#getByName()returns aLinkedList.HPackEncoder#findFullMatch()currently traverses it using indexed access, which causes repeated list traversal.Using sequential iteration avoids that overhead without changing lookup semantics.
JMH results for a full lookup:
The change is limited to replacing indexed traversal with sequential iteration.