Fix H2 stream flow control overflow - #708
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
Reset the affected stream when WINDOW_UPDATE overflows its window. Keep connection-level overflow as a connection error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9113 Section 6.9.1 requires a sender to ensure that a flow-control window does not exceed
2^31-1octets. If aWINDOW_UPDATEcauses the maximum flow-control window size to be exceeded, the affected stream or connection must be terminated as appropriate.For a stream, RFC 9113 requires
RST_STREAMwithFLOW_CONTROL_ERROR. For the connection, it requiresGOAWAYwithFLOW_CONTROL_ERROR.The connection-level path already reports a connection
FLOW_CONTROL_ERROR. The stream-level path currently throwsH2ConnectionExceptionas well, which escalates a stream-specific flow-control error to the entire connection.This change resets only the affected stream with
FLOW_CONTROL_ERRORand updates the existing overflow test to verify the stream-level error scope.RFC 9113 Section 6.9.1:
https://www.rfc-editor.org/rfc/rfc9113.html#section-6.9.1