-
Notifications
You must be signed in to change notification settings - Fork 636
fix(docker): make auth bootstrap safe for mounted and upgraded configs #3192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Adarsh-Me
wants to merge
3
commits into
apache:master
Choose a base branch
from
Adarsh-Me:fix-entrypoint-auth-bootstrap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 These two values are decoded differently, so identical configurations can read as a mismatch.
props.awkreturns the on-disk escaped form on purpose ("The value of get is intentionally not unescaped"), whileget_yaml_authenticator'sscalar()returns what snakeyaml decodes:java.util.Propertiesreads both spellings as the same class, so the WARN is spurious and the alignment this function exists for is skipped.Line 173 is the mirror of it:
set_prop_encoded "auth.authenticator" "${yaml_auth}"hands a snakeyaml-decoded scalar to the setter that skipsencode_prop_value. Harmless for a bare class name, wrong for any scalar carrying a backslash or leading space.Requested change: unescape before comparing and before the
exportbelow, either through aget_decodedmode inprops.awk(keeping the raw mode for the secret round trip that needs it) or an unescape here, and useset_proprather thanset_prop_encodedon line 173.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 5f50511. align_auth_config now reads the authenticator via a get-decoded mode (new get_prop wrapper) that unescapes like java.util.Properties before comparing with the snakeyaml scalar, so an escaped properties value and a plain yaml scalar no longer WARN; the yaml-to-properties write on line 173 goes through the encoding setter set_prop. Raw mode kept for the token-secret round trip. Covered by an escaped-authenticator regression case; suite passes.