Fix NotStartsWith residual evaluation to return correct result#3503
Open
ebyhr wants to merge 2 commits into
Open
Fix NotStartsWith residual evaluation to return correct result#3503ebyhr wants to merge 2 commits into
ebyhr wants to merge 2 commits into
Conversation
rambleraptor
approved these changes
Jun 15, 2026
rambleraptor
left a comment
rambleraptor
left a comment
Collaborator
There was a problem hiding this comment.
Couple nits, but looks great. Thanks for doing this!
rambleraptor
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Are these changes tested?
Yes - the added test fails if we revert this PR's change.
Are there any user-facing changes?
Yes - this PR fixes a correctness issue of
NotStartsWith.