Enable nested field statistics with inferred metrics limit - #3810
Open
jkasireddy wants to merge 1 commit into
Open
Enable nested field statistics with inferred metrics limit#3810jkasireddy wants to merge 1 commit into
jkasireddy wants to merge 1 commit into
Conversation
Author
|
@claude could you review this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2699
Rationale for this change
PyIceberg currently downgrades nested primitive fields to
counts, which prevents lower and upper bound statistics from being collected for nested fields.This change enables statistics collection for nested primitive fields and adds support for
write.metadata.metrics.max-inferred-column-defaults, following the behavior of the Iceberg Java implementation.When no explicit default metrics mode is configured, inferred metrics are limited to the configured number of fields. Primitive fields at the current struct level are prioritized before descending into nested fields. Explicit per-column metrics configuration continues to take precedence over the inferred limit.
Are these changes tested?
Yes.
Added regression tests covering:
write.metadata.metrics.max-inferred-column-defaultsLocal test results: