Arrow: Fix valuesRead accumulation in VectorizedDeltaEncodedValuesReader - #17121
Open
ebyhr wants to merge 1 commit into
Open
Arrow: Fix valuesRead accumulation in VectorizedDeltaEncodedValuesReader#17121ebyhr wants to merge 1 commit into
ebyhr wants to merge 1 commit into
Conversation
ebyhr
commented
Jul 7, 2026
| assertThat(batch2).containsExactly(70, 80, 90, 100); | ||
|
|
||
| assertThat(reader.totalValueCount()).isEqualTo(10); | ||
| assertThatThrownBy(() -> reader.readIntegers(1, 0)) |
Member
Author
There was a problem hiding this comment.
reader.readIntegers(1, 0) returns [110] without this PR fix.
ebyhr
force-pushed
the
ebi/parquet-vectorized
branch
from
July 10, 2026 10:56
a7a057c to
ea5dd96
Compare
ldudas-marx
approved these changes
Jul 13, 2026
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
ebyhr
force-pushed
the
ebi/parquet-vectorized
branch
from
August 13, 2026 00:26
ea5dd96 to
b3598bc
Compare
ebyhr
force-pushed
the
ebi/parquet-vectorized
branch
from
August 20, 2026 13:11
b3598bc to
a77c349
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VectorizedDeltaEncodedValuesReader.readValuesresetsvaluesReadto the current batch size on every call (valuesRead = total - remaining) instead of accumulating it (+=). On a multi-batch page read the overflow guardvaluesRead + total > totalValueCountsees a stale count and silently allows reads past the logical end of the page.The bug does not throw - DELTA_BINARY_PACKED mini-blocks are zero-padded to a fixed size, so the reader decodes the padding zeros as valid deltas and emits plausible-looking but wrong values. For example, a page of [10, 20, ..., 100] read in batches of 6 and 4, then read once more, returns 110 - the next extrapolated delta step - with no error.