AWS, Core: Implement RemoteSigningConfig - #17709
Conversation
ff9f453 to
60ed16e
Compare
|
@nastra @dramaticlly FYI |
|
@adutra This doesn't look like it needs to be stacked on the other PR. Can you please split them up? |
Hmm in this case we'd need @dramaticlly to change their PR #17627. They'd need to revert the changes to Are you OK with that @dramaticlly ? In this case we could split as follows:
UPDATE: I already reverted the removal of orphaned classes in this PR. |
Thanks @adutra for the coordination of the PR. I think it make sense for my #17627 to only focus on removing of deprecated class and leave |
This PR implements the changes introduced to the REST spec by apache#16822. In particular, it brings support for the newly-introduced `RemoteSigningConfig` object. This PR also removes signing-related elements that were deprecated for removal in 1.12.0: the legacy signer properties in `S3V4RestSignerClient`, as well as the S3-specific classes that are now orphaned: `S3SignRequest`, `S3SignResponse`, `S3SignRequestParser`, `S3SignResponseParser` and `S3ObjectMapper`.
54914fc to
ef5061d
Compare
|
@adutra one last comment, but other than that I think this is ready to go. |
|
@danielcweeks I addressed your last comment, PTAL. |
nastra
changed the title
danielcweeks
left a comment
danielcweeks
left a comment
There was a problem hiding this comment.
+1, Thanks @adutra!
5 participants
This PR implements the changes introduced to the REST spec by #16822. In particular, it brings support for the newly-introduced
RemoteSigningConfigobject.This PR also removes signing-related elements that were deprecated for removal in 1.12.0: the legacy signer properties in
S3V4RestSignerClient, as well as the S3-specific classes that are now orphaned:S3SignRequest,S3SignResponse,S3SignRequestParser,S3SignResponseParserandS3ObjectMapper.This PR may overlap with #17627. I suggest merging #17627 first, then I will update this one accordingly.