Core: Allow date to timestamp promotion for v3 tables - #17744
Open
rambleraptor wants to merge 1 commit into
Open
Core: Allow date to timestamp promotion for v3 tables#17744rambleraptor wants to merge 1 commit into
rambleraptor wants to merge 1 commit into
Conversation
The v3 spec allows promoting `date` to `timestamp` and `timestamp_ns`. Promotion to `timestamptz` or `timestamptz_ns` is not allowed, and promotion is rejected when the field is the source of a partition field whose transform would produce a different value after the promotion (`identity` and `bucket`; `year`, `month`, `day` and `void` are unaffected). Closes apache#16083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v3 spec allows for promoting a date -> timestamp / timestamp_ns.
This PR allows for the promotion and plumbs through the table formatVersion to make it possible.
There's also an edge case around partitioning for this promotion in particular. According to the spec,
This is only relevant for date -> timestamp / timestamp_ns promotions.