refactor(go): separate transport state and session state#3652
Merged
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3652 +/- ##
============================================
- Coverage 73.99% 73.62% -0.37%
Complexity 937 937
============================================
Files 1301 1286 -15
Lines 147389 140602 -6787
Branches 122949 116513 -6436
============================================
- Hits 109057 103519 -5538
+ Misses 34861 33845 -1016
+ Partials 3471 3238 -233
🚀 New features to boost your workflow:
|
2 tasks
hubcio
requested changes
Jul 13, 2026
chengxilo
force-pushed
the
refactor/go-sdk-client-state
branch
from
July 14, 2026 04:31
e6eea26 to
38d76d2
Compare
Contributor
Author
|
/ready |
hubcio
approved these changes
Jul 17, 2026
numinnex
approved these changes
Jul 17, 2026
spetz
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Relates to #3651
Rationale
Mixed state in a tech debt. It doesn't represent the client state correctly. Instead of map the tech debt from Rust SDK, I want to address it before #3650
What changed?
Separate transport state and session state.
Now
LoginUser/LoginPersonalAccessToken/Logoutwill be the only functions that control the session state.Local Execution
AI Usage
BREAKING CHANGE:
iggcon.Statetype and itsState*constants are removed, replaced byTransportStateandSessionState.iggcon.Statenow meansTransportStateDisconnected(not connected yet) rather thanStateShutdown(permanently dead).StateAuthenticatingis dropped with no replacement