fix(cpp): move bazel build config for bdd/cpp to foreign/cpp#3675
Open
slbotbm wants to merge 3 commits into
Open
fix(cpp): move bazel build config for bdd/cpp to foreign/cpp#3675slbotbm wants to merge 3 commits into
slbotbm wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3675 +/- ##
============================================
- Coverage 73.99% 73.93% -0.07%
Complexity 937 937
============================================
Files 1301 1301
Lines 147393 147393
Branches 122945 123019 +74
============================================
- Hits 109063 108974 -89
- Misses 34858 34859 +1
- Partials 3472 3560 +88
🚀 New features to boost your workflow:
|
slbotbm
force-pushed
the
cpp-bdd-softlink
branch
2 times, most recently
from
July 15, 2026 20:50
44c0cca to
13e83ff
Compare
hubcio
previously approved these changes
Jul 16, 2026
slbotbm
force-pushed
the
cpp-bdd-softlink
branch
from
July 17, 2026 11:03
a2f0b76 to
188f35f
Compare
hubcio
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3662, we were facing a problem: we have two lockfiles in our repo. bdd/cpp declares the sdk as a local dependency, so the sdk's dependencies are also saved into bdd's lockfile. When the sdk's lockfile is updated, bdd's lockfile also needs to be updated, but it does not happen, and there is no way to tell dependabot to update bdd's lockfile.
This pr removes the bazel config inside bdd/cpp and adds a softlink to the c++ files and headers in bdd/cpp, allowing the building of bdd/cpp binary to happen inside foreign/cpp, thus solving the problem of tow lockfiles.
also upgrades bazel to 9.2.0
also reordered the tests/ directory a bit, dividing it into three folders: bdd/, e2e/, and unit/, and changed the file names a bit.