test(bdd): fail Rust BDD runner on undefined steps#3680
Open
seokjin0414 wants to merge 1 commit into
Open
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
hubcio
approved these changes
Jul 16, 2026
The cucumber World::run default treats an unmatched step as skipped and still exits 0, so CI stays green when a shared feature file gains a step that has no matching definition in the Rust runner. Run both entry points through fail_on_skipped so undefined steps turn the suite red. The feature files use no tag filtering, so nothing is legitimately skipped. Refs apache#3634 Signed-off-by: shin <sars21@hanmail.net>
seokjin0414
force-pushed
the
3634-bdd-strict-rust
branch
from
July 17, 2026 11:14
bf3adfd to
b04d574
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3554 — Rust half of #3634 (Go half in a separate PR).
The Rust BDD entry points used cucumber's default
World::run, which treats a step without a matching definition as skipped and still exits 0 — CI stays green while steps silently stop running whenever a shared feature file gains a step the runner doesn't implement. Both entry points now run throughfail_on_skipped(), so undefined steps turn the suite red. The shared feature files use no tag filtering, so nothing is legitimately skipped.Verification (local server with
--with-default-root-credentials, fresh data dir per run):cargo test -p bdd --features bdd --test basic_messaging→ exit 0,17 steps (17 passed)And the server should sing a lullabyappended to the feature): exit 101, step reportedStep doesn't match any function,18 steps (17 passed, 1 failed)cargo fmt/cargo clippy -D warningscleanRefs #3634