Skip to content

Fix partial insert handling for null measurements #17879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Caideyipi wants to merge 5 commits into
base: master
Choose a base branch
from

Fix failed measurement WAL serialization tests

ab35850
Select commit
Loading
Failed to load commit list.
Open

Fix partial insert handling for null measurements #17879

Fix failed measurement WAL serialization tests
ab35850
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 10, 2026 in 3m 8s

Quality Gate passed

Issues
31 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
3.3% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 156 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/MemUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4R3ZEwbPSLU04QfG&open=AZ6r4R3ZEwbPSLU04QfG&pullRequest=17879

Check failure on line 4761 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4RuVEwbPSLU04Qe1&open=AZ6r4RuVEwbPSLU04Qe1&pullRequest=17879

Check failure on line 202 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tablet/parser/TabletInsertionEventParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4R2REwbPSLU04QfF&open=AZ6r4R2REwbPSLU04QfF&pullRequest=17879

Check warning on line 322 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertRowNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'shouldSerializeMeasurementToWAL' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4RzsEwbPSLU04QfC&open=AZ6r4RzsEwbPSLU04QfC&pullRequest=17879

Check warning on line 826 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertTabletStatement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 114 to 64, Complexity from 38 to 14, Nesting Level from 5 to 2, Number of Variables from 32 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4RwZEwbPSLU04Qe6&open=AZ6r4RwZEwbPSLU04Qe6&pullRequest=17879

Check warning on line 465 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tablet/parser/TabletInsertionEventParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 148 to 64, Complexity from 41 to 14, Nesting Level from 4 to 2, Number of Variables from 29 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6ra3Qoze_0heoHOrVq&open=AZ6ra3Qoze_0heoHOrVq&pullRequest=17879

Check warning on line 745 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertRowNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4RzsEwbPSLU04Qe_&open=AZ6r4RzsEwbPSLU04Qe_&pullRequest=17879

Check warning on line 1086 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertTabletNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'getValidMeasurementNumberForWAL' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6vhX61d-C0C1PL3rue&open=AZ6vhX61d-C0C1PL3rue&pullRequest=17879

Check warning on line 1144 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertTabletNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'shouldSerializeMeasurementToWAL' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6vhX61d-C0C1PL3rug&open=AZ6vhX61d-C0C1PL3rug&pullRequest=17879

Check warning on line 488 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertRowNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4RzsEwbPSLU04Qe9&open=AZ6r4RzsEwbPSLU04Qe9&pullRequest=17879

Check warning on line 199 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/schema/NormalSchemaFetcher.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 182 to 64, Complexity from 25 to 14, Nesting Level from 3 to 2, Number of Variables from 41 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4R0nEwbPSLU04QfD&open=AZ6r4R0nEwbPSLU04QfD&pullRequest=17879

Check warning on line 661 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertRowNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4RzsEwbPSLU04Qe-&open=AZ6r4RzsEwbPSLU04Qe-&pullRequest=17879

Check warning on line 1096 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertTabletNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,075'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6vhX61d-C0C1PL3ruf&open=AZ6vhX61d-C0C1PL3ruf&pullRequest=17879

Check warning on line 427 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertRowNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4RzsEwbPSLU04Qe8&open=AZ6r4RzsEwbPSLU04Qe8&pullRequest=17879

Check warning on line 285 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AbstractWritableMemChunk.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'serializeSchemaToWALBytes' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6vvEdOF1Qkhlkw4UmS&open=AZ6vvEdOF1Qkhlkw4UmS&pullRequest=17879

Check warning on line 339 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AlignedWritableMemChunk.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 74 to 64, Complexity from 27 to 14, Nesting Level from 6 to 2, Number of Variables from 25 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6vvEZFF1Qkhlkw4UmR&open=AZ6vvEZFF1Qkhlkw4UmR&pullRequest=17879

Check warning on line 250 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowStatement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4Rv8EwbPSLU04Qe5&open=AZ6r4Rv8EwbPSLU04Qe5&pullRequest=17879

Check warning on line 886 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertBaseStatement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "columnCategories" which hides the field declared at line 86. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4RxEEwbPSLU04Qe7&open=AZ6r4RxEEwbPSLU04Qe7&pullRequest=17879

Check failure on line 118 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tablet/parser/TabletInsertionEventParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4R2REwbPSLU04QfE&open=AZ6r4R2REwbPSLU04QfE&pullRequest=17879

Check warning on line 386 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/util/TabletStatementConverter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 108 to 64, Complexity from 27 to 14, Nesting Level from 5 to 2, Number of Variables from 22 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6ra3Pxze_0heoHOrVp&open=AZ6ra3Pxze_0heoHOrVp&pullRequest=17879

Check warning on line 3491 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 149 to 64, Complexity from 29 to 14, Nesting Level from 5 to 2, Number of Variables from 26 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4RuVEwbPSLU04Qe2&open=AZ6r4RuVEwbPSLU04Qe2&pullRequest=17879

Check failure on line 393 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertTabletStatement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 29 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6vhX41d-C0C1PL3rud&open=AZ6vhX41d-C0C1PL3rud&pullRequest=17879

Check warning on line 113 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/transform/statement/PipeConvertedInsertRowStatement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6ra3Q1ze_0heoHOrVr&open=AZ6ra3Q1ze_0heoHOrVr&pullRequest=17879

Check warning on line 280 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertRowNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'getValidMeasurementNumberForWAL' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4RzsEwbPSLU04QfB&open=AZ6r4RzsEwbPSLU04QfB&pullRequest=17879

Check warning on line 3078 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 97 to 64, Complexity from 17 to 14, Nesting Level from 7 to 2, Number of Variables from 24 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6r4RuVEwbPSLU04Qe3&open=AZ6r4RuVEwbPSLU04Qe3&pullRequest=17879
View more details on SonarQubeCloud