Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an opt-in microbenchmark for the compiled non-trivial wildcard cache introduced by #18672.
PathPatternNode.getMatchChildren, alternating execution order by round.-Diotdb.path.pattern.node.perf.enabled=trueis set.Example:
mvn -pl iotdb-core/node-commons -Dtest=PathPatternNodePerformanceTest -Diotdb.path.pattern.node.perf.enabled=true testThe workload can be tuned with the
iotdb.path.pattern.node.perf.*system properties documented by the test skip message.Local benchmark results
Run on 2026-09-21 with Windows 11 (build 26200), JDK 17.0.15, and an Intel Core i9-13900H. The command used for both revisions was:
mvn -pl iotdb-core/node-commons -Dtest=PathPatternNodePerformanceTest -Diotdb.path.pattern.node.perf.enabled=true -Diotdb.path.pattern.node.perf.wildcard-counts=1,10,100 -Diotdb.path.pattern.node.perf.query-count=1000 -Diotdb.path.pattern.node.perf.warmup-lookups=2000 -Diotdb.path.pattern.node.perf.lookups=20000 -Diotdb.path.pattern.node.perf.rounds=7 testThe PR base is
9be80ead1dc(the #18672 cache implementation); the PR head ise78adaf878e. The benchmark's legacy column emulates the pre-#18672 implementation, while the cached column callsPathPatternNode.getMatchChildren:For the cached path alone, the same run on the PR base versus the PR head was:
9be80ead1dc(ns/lookup)e78adaf878e(ns/lookup)#18685 only adds the benchmark test (the two-line OPC UA reference cleanup in the head is unrelated to
PathPatternNode); the base/head differences above are single-run microbenchmark noise, not a production-path change. The signal is the comparison against the emulated pre-#18672 path: about 5-6x higher throughput and 80-83% lower lookup latency with the compiled-pattern cache.Testing
mvn spotless:apply -pl iotdb-core/node-commons- passed.PathPatternNodePerformanceTestwith the command above - passed on the PR head (1 test, 0 failures).This PR has:
Key changed/added classes
PathPatternNodePerformanceTest