Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18690 +/- ##
=========================================
Coverage 44.35% 44.36%
Complexity 712 712
=========================================
Files 5483 5483
Lines 394207 394215 +8
Branches 51177 51182 +5
=========================================
+ Hits 174861 174889 +28
+ Misses 219346 219326 -20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pipe tablet batch responses carry per-row redirection statuses. Table-model
InsertTabletStatementandInsertRowsStatementbatches can contain multiple device IDs, so attaching a single statement path to those statuses can create invalid leader-cache entries and misroute later writes.This change:
Validation
JUnitCore: 23 tests passed forIoTDBDataNodeReceiverTestandLeaderCacheUtilsTest.mvn -pl iotdb-core/datanode spotless:check '-DskipTests' '-Dcheckstyle.skip=true'passed.git diff --checkpassed.The normal Maven test invocation is blocked by pre-existing stale cross-module generated artifacts/dependencies in the checkout (
TypeServices, ANTLR, and Thrift symbols in unmodified files); the changed classes compile independently and the targeted tests pass.