feat(desktop): answer structured form interactions

[me2seeks]

Summary

• render Runtime Host-owned structured form interactions in the Desktop composer for both the main conversation and Side Chat
• preserve omitted optional fields separately from explicit empty or false values, while validating all six primitive field kinds through the shared core contract
• decode renderer responses at the IPC boundary and retire prompts only after Host settlement or its projected acknowledgement

Why

PR #4379 establishes the durable form interaction contract and Runtime Host continuation authority. Desktop still needs a surface adapter so a tool can collect bounded structured input without falling back to an untyped text question or inventing a second pending-interaction owner in the renderer.

This PR is stacked on #4379 and implements the Desktop slice of the rollout in #4364. It does not add provider-specific form state or change the MCP wire path.

Screenshots

Before, Desktop could only render the fixed question prompt. After, the same composer slot renders a structured form, preserves optional field intent, and reports field-local validation errors.

Before: fixed question prompt	After: structured form prompt

Usability states

Optional field included with explicit true	Field-local validation after submit

Test plan

• npm run build
• 122 focused UI/Desktop interaction tests
• 45 focused storage tests with a non-worktree temporary directory
• Storybook interaction check at 1440x900: defaults, optional boolean inclusion/value, invalid required string

Part of #4364.

[Astro-Han]

PR #4384 — 098cac3 — blind review sealed

Summary: Desktop structured-form answer surface stacked on #4379. Exact head 098cac3a547454b51cf0a37c36b775024583ddc9 frozen. Source is approvable with comments; inherits #4379's 2×P2+1×P3. No simplify finding. Full build passed; 91 focused Desktop/UI tests passed; exact-head hosted test green. 0 reviews/0 threads on stacked base; mergeable on stacked base.

Findings (reproducible):

• P2 — drafts reset on fields identity change — form resets drafts when fields array identity changes. Runtime Host recovery republishes same pending request as freshly projected objects; React DOM probe typed release-candidate, rerendered clone with same request ID → input became empty. Any pending-set change can trigger. Fix: reset only on stable requestId/semantic revision, add recovery regression.
• P2 — constraints not rendered — surface enforces minimum/maximum, length, cardinality, format but renders only generic invalid message. Production render of integer min=max=997 + date-time field contained neither 997 nor date-time, so legal opaque forms can be undiscoverably unanswerable. Fix: render visible/accessible constraint help and cover formats/ranges.

Gating: hosted test green on stacked base; full stack inherits #4379 risk. Direct current-main merge has explicitly ignored epoch conflict plus generated inventory conflicts (base stack not landed) — not retained as finding.

Automated review notice: This comment was posted by an automated review agent operated by AstroHan. It is not an independent human review and does not replace one.

---

简体中文

本条结论来自 @捣蛋鬼 在 exact head 098cac3 的独立盲审，已按 @me2seeks 指示排除 compatibility epoch 冲突的计分。编排仅核对 head 未漂移与 CI 状态。

[me2seeks]

Fixed both findings in 28ad94a. Draft state is now keyed by requestId, so a recovery projection of the same request keeps local edits while a different request resets them. Field constraints are rendered visibly and linked to their field group through aria-describedby.

Added a DOM regression covering cloned fields, request replacement, ranges, formats, and accessible descriptions.

[me2seeks]

The previous CI failure was the renderer architecture ledger after the rebase, not a form test failure. This head refreshes that ledger and retains the form variant in the composer interaction union alongside main's Goal projection ownership. Local full build, renderer architecture check, UI form regression, and AppShell response regression pass.

[me2seeks]

Rebased onto the updated parent head (cd16fd613) and completed the composer-queue follow-up in 4e66b42ec.

The parent narrowed ComposerInteraction to the request kinds a surface without form support can render, so a pending form can no longer hide the composer behind an empty prompt. This branch installs the Desktop form surface, so the shared queue now accepts form_request again and retires it on form_answer_ack, matching the boundary/question siblings; the parent coverage that asserted forms stay out of the queue is replaced with enter/leave and rehydration coverage for the form kind.

Validation on 4e66b42ec: full npm run build, Desktop typecheck including stories, renderer architecture check, @maka/ui suite 318/318, @maka/desktop dist suite 1956/1956.

[me2seeks]

Rebased onto the updated parent head (3dd69e776, which fixes the answer-envelope byte domain) and closed the architecture ratchet in 78bd322de.

The form responder wiring adds tokens to two debt-tracked legacy files; single-statement conditionals collapse to braceless form so both stay at or below the parent baseline (app-shell-session-events.ts 2974, app-shell.tsx 15778 vs base 15779), and the renderer architecture ledger is refreshed to match.

Validation on 78bd322de: full build; ratchet passes against the current parent head; @maka/ui form suites 14/14; focused Desktop form/quote suites 17/17; Desktop dist suite 1956/1956; baseline architecture check green.

[me2seeks]

Rebased onto the updated parent head (51bacd210, strict escaped-envelope admission) in 64b659b05; the child delta is unchanged and the renderer architecture ratchet still passes against the new parent. Validation: full build; @maka/ui form suites 14/14; Desktop dist suite 1956/1956.

[me2seeks]

Rebased onto the current parent head (9ec0c5f9a, format-aware envelopes, rebased onto main) in 2b7430c05.

Main rewrote the transcript reading-position block while the parent moved, so the token-debt golf was re-measured from scratch against the new base: seven single-statement conditionals collapse to braceless form and app-shell.tsx lands at 15,690 nonTriviaTokens, two under the parent baseline; the renderer ledger is regenerated to match. The hosted test failure on the intermediate head was the stale astryx surface inventory (the form prompt and story bring coverage to 245 files), now refreshed.

Validation on 2b7430c05: full build; Desktop typecheck; ratchet passes against the current parent; @maka/ui form suites 14/14; Desktop dist suite 2009/2009; astryx inventory and baseline architecture checks green; exact-head hosted test is green.