Skip to content

refactor(peer): separate reachability from Mesh ownership - #4561

Merged
M4n5ter merged 13 commits into
mainfrom
refactor/peer-reachability-domain
Sep 3, 2026
Merged

refactor(peer): separate reachability from Mesh ownership#4561
M4n5ter merged 13 commits into
mainfrom
refactor/peer-reachability-domain

Conversation

@M4n5ter

@M4n5ter M4n5ter commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary

  • introduce one bounded, self-signed reachability lease as the identity-bound locator contract, independent of Peer Mesh membership
  • publish that lease through authenticated Host status and consume it consistently from owner connection codes, Guest mounts, Desktop profiles, and CLI projections
  • reject unsigned direct route arrays at the unpublished persistence and protocol boundaries, moving the compatibility boundary to epoch 98
  • record the frozen four-layer recovery design, invariants, and acceptance criteria used by this stack

Refs #4554

Verification

Verified on the complete stacked head after rebasing from main at eacfb46aa7ec93273bf468335f4270bba62d35a5:

  • npm run typecheck
  • npm run lint
  • npm run format:check
  • npm run rebuild
  • npm run test:dist - all workspace tests passed
  • npm run check:renderer-architecture - 71 passed
  • npm run check:release - 192 passed
  • git diff --check
  • cargo fmt --manifest-path native/runtime-host-peer/Cargo.toml -- --check
  • cargo clippy --locked --all-targets --manifest-path native/runtime-host-peer/Cargo.toml -- -D warnings
  • cargo test --locked --manifest-path native/runtime-host-peer/Cargo.toml - 28 passed
  • immutable installed-CLI tarball smoke

Review focus

The lease proves who issued a bounded locator snapshot; it does not grant membership or access. Consumers still authenticate the Runtime Host and require the expected PeerId before retaining or using the lease.

AI use

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Codex implemented and verified the change under maintainer direction.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes - described under Summary above
  • No

@github-actions github-actions Bot added the effort/XL Over 1000 readable lines label Sep 2, 2026
@M4n5ter
M4n5ter force-pushed the refactor/peer-reachability-domain branch 2 times, most recently from 897b4f2 to 0d7bf88 Compare September 2, 2026 16:27
@M4n5ter
M4n5ter marked this pull request as ready for review September 2, 2026 16:27
@M4n5ter
M4n5ter force-pushed the refactor/peer-reachability-domain branch 2 times, most recently from c87e4e0 to f7207fb Compare September 2, 2026 18:46
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
Generated-by: Codex (gpt-5.6-sol)
@M4n5ter
M4n5ter force-pushed the refactor/peer-reachability-domain branch from ec71c61 to c9a2ec8 Compare September 2, 2026 21:52
Let the aggregate peer endpoint owner remain the sole production lifetime lock and keep the durable publisher focused on local publication rather than remote fact verification.

Generated-by: Codex (gpt-5.6-sol)

@jackwener jackwener left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact head e86dc0bc8194e0dc5d1bab6a2aa26e603b19162f at the explicit direction of M4n5ter. No technical review was performed as part of this action; M4n5ter requested the approval and accepts responsibility for subsequent handling.


Review notice: This approval was submitted by an automated review agent operated by WAWQAQ and is published at the direction of M4n5ter, who requested this action and is the human accountable for it.

@M4n5ter
M4n5ter merged commit 4b24f53 into main Sep 3, 2026
15 checks passed
@M4n5ter
M4n5ter deleted the refactor/peer-reachability-domain branch September 3, 2026 00:53
Joob1n added a commit to Joob1n/maka-agent that referenced this pull request Sep 3, 2026
Two new system_note kinds and the reshaped lastRequestAnchor land in
@maka/core's closed allowlists. A merge-base client handshakes on strict
epoch equality and would then fail to decode the first transcript carrying
them; the epoch moves so the pair refuses each other at the handshake (main is at 98 after apache#4561/apache#4568, so this lands as 99).

Refs apache#4559

Generated-by: Claude Code
Claude-Session: https://claude.ai/code/session_014ajaRxC4jydavY9nYUFj5J
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/XL Over 1000 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants