fix(desktop): treat teardown as cancellation - #4562
Open
Phoenix500526 wants to merge 1 commit into
Open
Conversation
Pending renderer teardown is an expected observation outcome. Represent it explicitly across IPC so Electron does not report a handler failure or expose an empty success value. CLOSES apache#4434 Generated-by: OpenAI Codex Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pending Session and transcript observations rejected their readiness promises
when the renderer intentionally released them during startup. Those expected
teardowns escaped the Electron IPC handlers as errors.
Distinguish caller-initiated cancellation from genuine initialization failure,
then carry an explicit
readyorcancelledresult across the Main/Preload IPCboundary. Preload now stops cancelled listeners without reporting a Session as
seeded or reading a missing transcript result. Genuine seed and transcript-open
failures continue to reject unchanged.
Fixes #4434
Verification
npm --workspace @maka/desktop run typechecknpm --workspace @maka/desktop run build:testnpm --workspace @maka/desktop run check:architecture: 71 fixture testspassed and the renderer architecture check passed
observation handler errors
AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex implemented the cancellation contract and
regression tests, then reviewed and verified the resulting diff.
Checklist
Does this PR entail a change in behavior?