Skip to content

chore(deps): bump qs and fast-uri to clear the production dependency audit - #4578

Merged
Astro-Han merged 1 commit into
apache:mainfrom
Joob1n:chore/bump-qs-audit
Sep 2, 2026
Merged

chore(deps): bump qs and fast-uri to clear the production dependency audit#4578
Astro-Han merged 1 commit into
apache:mainfrom
Joob1n:chore/bump-qs-audit

Conversation

@Joob1n

@Joob1n Joob1n commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

npm audit --omit=dev reports two advisories against production dependencies: qs@6.15.3 (moderate — array-limit bypass via bracket-key comma parsing; DoS via attacker-controlled isBuffer), reached through @larksuiteoapi/node-sdk in @maka/runtime, and fast-uri@3.1.x (high — host confusion and SSRF via IDN, IPv6 and percent-decoding normalization; GHSA-5jgf-p345-68v8 and siblings). The Build CLI release candidate step and the Dependency audit workflow fail on any such advisory, so every PR on main currently fails regardless of its content (e.g. https://github.com/apache/maka/actions/runs/33648229722, https://github.com/apache/maka/actions/runs/33655577529). qs resolves to 6.16.0 and fast-uri to 3.1.7; the production dependency notices (Desktop and CLI) are regenerated for the new versions.

Verification

npm audit --omit=dev --audit-level=moderate → clean; npm audit --omit=dev --workspace maka-agent --jsontotal: 0; npm run check:third-party-notices and npm run check:cli-third-party-notices → clean. No source changes.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Claude Code — diagnosis and the lockfile bump; verified by the author.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

https://claude.ai/code/session_014ajaRxC4jydavY9nYUFj5J

@github-actions github-actions Bot added the effort/XS Under 10 readable lines label Sep 2, 2026
@Joob1n
Joob1n force-pushed the chore/bump-qs-audit branch 2 times, most recently from a6ae809 to 929993c Compare September 2, 2026 16:14

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Joob1n
Joob1n force-pushed the chore/bump-qs-audit branch 2 times, most recently from cab7320 to 64818bd Compare September 2, 2026 16:37
@Joob1n Joob1n changed the title chore(deps): bump qs to 6.16.0 to clear the CLI production audit chore(deps): bump qs and fast-uri to clear the production dependency audit Sep 2, 2026
@Joob1n

Joob1n commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

The remaining test failure is the Desktop e2e transcript-scroll.spec.ts:251, a main regression introduced by #4184 and hidden until now because every main push has been dying at the production audit this PR fixes — bisected on clean checkouts and reported on #4184. Nothing in this PR touches the renderer; once #4184's regression is fixed this should go green on rebase.

…audit

`npm audit --omit=dev` reports two advisories against production
dependencies: qs 6.15.3 (moderate: array-limit bypass via bracket-key comma
parsing; DoS via attacker-controlled isBuffer), reached through
@larksuiteoapi/node-sdk in @maka/runtime, and fast-uri 3.1.x (high: host
confusion and SSRF via IDN, IPv6 and percent-decoding normalization). The
"Build CLI release candidate" CI step and the Dependency audit workflow fail
on any such advisory, so every PR on main is red until the lockfile moves.
qs resolves to 6.16.0 and fast-uri to 3.1.7; the production dependency
notices are regenerated for the new versions.

Generated-by: Claude Code
Claude-Session: https://claude.ai/code/session_014ajaRxC4jydavY9nYUFj5J
@Joob1n
Joob1n force-pushed the chore/bump-qs-audit branch from 64818bd to 4fe192a Compare September 2, 2026 18:13
@Astro-Han
Astro-Han merged commit f9d3d7e into apache:main Sep 2, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/XS Under 10 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants