Add Maven 4 to the CI matrix - #129
Merged
Merged
Conversation
Adds the Maven 4 line to the shared verify matrix, as most of the estate already does, so incompatibilities show in CI rather than at a user.
…project Version 1.0 resolves the resource bundle through the Maven 2 artifact resolver, which finds nothing on Maven 4.
Maven 4 on Windows holds its log file open, so the clean before the build failed to delete target/log.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
maven4-enabled: trueto the shared verify workflow. Theshared-resourcestest project pinned maven-remote-resources-plugin 1.0, whose Maven 2 artifact resolver finds nothing on Maven 4 (org.apache:apache-jar-resource-bundle:jar:1.4 (absent)); it uses 3.3.0 now.Verified:
mvn -P run-its verifyon 4.0.0-rc-6 → 11 ITs passed;IT003SharedResourceInclusionalso passed on 3.10.0-rc-1.