Conversation
When testCompile scans dependency state, the test classpath may list target/classes even if no main sources were compiled. Treat a missing path like an empty directory instead of logging I/O warnings and recording unstable dependency metadata. Fixes apache#1124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[WARNING] I/O error reading dependency state: …/target/classesduringtestCompileon projects with nosrc/main/java(tests-only modules).testCompilestays stable without false "changed dependency" rebuilds.DependencyStateTestcoverage and invoker ITMCOMPILER-1124_test-only-testcompile.Fixes #1124
Root cause
Since 3.16.0 (#1102), dependency state scanning walks test classpath elements. Tests-only projects still list
${project.build.outputDirectory}on the classpath even when that directory was never created. A missing path was handled as a regular file read failure, which logged a warning and stored anunreadablefingerprint.Test plan
mvn -Dtest=DependencyStateTest testmvn -Prun-its verify -Dinvoker.test=MCOMPILER-1124_test-only-testcompile -DskipTestsManual reproducer (
lprimak/maven-test-compiler-reproducer) withcompiler.plugin.version=3.16.1-SNAPSHOT: no dependency-state warning onclean test-compile/test-compileI hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.